Show Posts
1
Warrior / Re: Warrior Hotkeys
« on: October 12, 2014, 03:51:42 AM »
Howdy, folks,
I stumbled on your GINA warrior trigger package when searching the web for tips when playing my warrior alt, and wanted to thank you for posting these. I also wanted to pass along a couple tips to improve the performance of a couple of them:
The regex in the Rampage trigger is very expensive in its current form. If you make the following changes, the match testing will go much faster:
Search Text: ^{S} \w+ (?<char>\w+(`s pet){0,1}) for {N} points of damage. \(Rampage\)$
Display Text: {S} - ${char} - {N}
You can use the Log Search tool to get an idea of the speed difference -- use the search text in the "Search for specific text", and run a search against a character's log. For reference, GINA can parse the line above at about 83,000 lines per second on my machine versus about 1,500 lines per second for the original version.
Also, the melee damage > 34000 triggers can be condensed into a single trigger:
Search Text: ((bashes)|(claws)|(hits)|(kicks)|(pierces)|(punches)|(slashes)) YOU for {N>34000}
This one is less dramatic of an improvement than the rampage trigger, though, at 90,000 lines per second versus 73,000 lines per second for the original (on my machine).
Gimagukk
I stumbled on your GINA warrior trigger package when searching the web for tips when playing my warrior alt, and wanted to thank you for posting these. I also wanted to pass along a couple tips to improve the performance of a couple of them:
The regex in the Rampage trigger is very expensive in its current form. If you make the following changes, the match testing will go much faster:
Search Text: ^{S} \w+ (?<char>\w+(`s pet){0,1}) for {N} points of damage. \(Rampage\)$
Display Text: {S} - ${char} - {N}
You can use the Log Search tool to get an idea of the speed difference -- use the search text in the "Search for specific text", and run a search against a character's log. For reference, GINA can parse the line above at about 83,000 lines per second on my machine versus about 1,500 lines per second for the original version.
Also, the melee damage > 34000 triggers can be condensed into a single trigger:
Search Text: ((bashes)|(claws)|(hits)|(kicks)|(pierces)|(punches)|(slashes)) YOU for {N>34000}
This one is less dramatic of an improvement than the rampage trigger, though, at 90,000 lines per second versus 73,000 lines per second for the original (on my machine).
Gimagukk